cmckni3 / ruby-jasperserver

Rails integration for JasperSoft Reports
MIT License
19 stars 15 forks source link

update ruby version in tests #17

Open ceochronos opened 6 years ago

ceochronos commented 6 years ago

Hi,

I was about to create an issue regarding the old version of rest-client but I see that issue has already been taken care of.

However, test are failing due to we are testing against an unsupported combination of Ruby and rest-client

Can we remove all unsupported ruby versions and add current versions? According to https://www.ruby-lang.org/en/downloads/branches/, as of today, the only supported versions are: 2.3, 2.4 y 2.5.

I think I can do it.

I will start working on it in a different branch in the fork I just created.

ceochronos commented 6 years ago

@cmckni3 Tests in travis are failing (https://github.com/ceochronos/rails-jasperserver/commits/develop), this is due to the test app which is in rails 3 (rails 3 is not supported anymore) and some gems (protected_attributes) are not supported in newer versions of rails; and I think they are not longer required.

I am trying to test it locally to avoid so many commits, but I cannot figure out how docker connects to rake to run the tests. This is related to #15. Could you provide some insight about this, then I could expand it in the Readme file?

Also, Do we really need a rails test app?, I think test can run outside rails, the gem does not use something rails specific, is it? In fact, the gem can be used in a generic Ruby script.

cmckni3 commented 6 years ago

Yeah I haven’t updated this or tested it against a real report instance in awhile. #15 was to get a report instance running in Docker for development. I ran into licensing issues I believe.

The rails test application can be scrapped but keep the vcr recordings.

ceochronos commented 6 years ago

Testing is hard, I know; and as far as I know gem is working fine in rails 4.x and 5.x; I am using rails 5.1.6 in production.

I'll try to do something to make this work.

cmckni3 commented 6 years ago

I’m fine with dropping support for Ruby 1.9 and bumping the major version.

cmckni3 commented 6 years ago

I dropped support for Ruby < 2.3. Ruby 2.2 is still running on Travis but is allowed to fail.