search

cmckni3 / ruby-jasperserver

Rails integration for JasperSoft Reports
MIT License
19 stars 15 forks source link

Get report in a variable #3

Closed ceochronos closed 9 years ago

ceochronos commented 9 years ago

Another nice feature is the ability to get the report in a file or in a variable in order to send the report to the browser or as an attachment in an email.

cmckni3 commented 9 years ago

Sorry, I shouldn't have merged this. I'm still trying to wake up haha.

It looks good but I would prefer the code to be in a separate method.

Basically, remove the control coupling, save_file = false.