cmcrawford2 / memory-game

Memory card game from 1968.
https://boisterous-palmier-c30f9d.netlify.app/
MIT License
1 stars 4 forks source link

Improved UI for the 2 player mode #15

Closed alexpalade closed 1 year ago

alexpalade commented 1 year ago

I made the 2 player mode style a bit clearer and better positioned. Here's a before and after.

Disclaimer: styling is subjective and I'm not a designer, feel free to change it to you liking, e.g. background colors, border radius, spacing. ☺️ I can amend stuff mentioned here if I missed or made a mistake.

Changes

The .multiplayer display uses flexbox now. I toggle a single player-active class to show whose turn it is (instead of different .player0 and .player1 colors). I replaced the two #player0Status and #player1Status with a single #player-status for which I change the textContent. I also renamed #player1Score to #player1-score (idem for player 2) for consistency.

netlify[bot] commented 1 year ago

Deploy Preview for classic-memory-card-game ready!

Name Link
Latest commit 957927e0a4d42bec552a76bbd079d2fba48d3a19
Latest deploy log https://app.netlify.com/sites/classic-memory-card-game/deploys/6540e111d235e20008d1ffb7
Deploy Preview https://deploy-preview-15--classic-memory-card-game.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cmcrawford2 commented 1 year ago

Thanks! It looks good!