cmd-johnson / deno-oauth2-client

Minimalistic OAuth 2.0 client for Deno.
MIT License
45 stars 9 forks source link

BREAKING: remove `OAuth2ClientConfig.defaults` #49

Closed iuioiua closed 6 months ago

iuioiua commented 10 months ago

Closes #41

iuioiua commented 10 months ago

WDYT, @cmd-johnson?

cmd-johnson commented 10 months ago

I'm not quite sure tbh The defaults property holds data that can be overridden in each request, while the other properties are basically constant between all requests. I feel like promoting e.g. scope to the top level could suggest that that's what's used at all times, while nesting it into defaults makes it obvious that it's just... the default :sweat_smile:

Not that it would make much of a difference in practice, though :shrug: Anyway, seeing as this would be a breaking change, I'd rather hold off on merging this just yet until the OIDC client (#39) is done