search

cmd-ntrf / jupyter-desktop-server

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Feature request: enable both MATE and XFCE4 #1

Open bartoldeman opened 1 year ago

bartoldeman commented 1 year ago

the mate branch simply hardcodes mate-session. It would be nice to support both MATE and XFCE4 (via xfce4-session) dynamically by pressing to different icons, since some software works better with XFCE4 (ANSYS Mechanical Workbench, apparently).

cmd-ntrf commented 1 year ago

when running vncserver on a cluster directly you can then just change mate-session to xfce4-session in $HOME/.vnc/xstartup but the extension ignores this.

cmd-ntrf commented 1 year ago

The content of $HOME/.vnc/xstartup is probably ignore because we explictly provide a value to the -xstartup flag here: https://github.com/cmd-ntrf/jupyter-desktop-server/blob/mate/jupyter_desktop/__init__.py#LL18C1-L18C1

Since it's a shell script, we could first look if the file is defined and if it is ignore the flag.

We could also as you suggest have two icons, one for each Desktop provider. However, I am wondering if the common user would care about Xfce4 vs Mate.

bartoldeman commented 1 year ago

Sure for most users it does not matter whether you give them Mate or XFCE. This is just about users of Ansys Workbench, which apparently doesn't work correctly with Mate, but works well with XFCE4, and we need to be able to point them to an alternative in tickets.

cmd-ntrf commented 1 year ago

Should XFCE4 be the default?

In which case, we could probably move back to using the upstream: https://github.com/jupyterhub/jupyter-remote-desktop-proxy

bartoldeman commented 1 year ago

I'd be hesitant to make it the default now, since it hasn't had a lot of testing and users may be surprised by the sudden change in look & feel.