Closed Sam-Guliker closed 6 years ago
Sweet, a bit to late, but here’s some feedback anyway!
node_modules/
to .gitignore
*.DS_Store
, it’s not needed. Now it also checks for files called foo.DS_Store
(but those don’t exist).git
to gitignore is not needed, it’s always ignoredemail
and url
in package.json
don’t exist?! you can add an email (and a url) to the author
property instead. See npm’s docs on package.json
for more infopackage.json
to a repo on GitHub, you can do "repository": "Senmetsu/week2-npm"
!package.json
are supposed to be about the package!"main": "index.js"
in package.json
is not needed: that’s the default already"bugs": "https://github.com/Senmetsu/week2-npm/issues"
, it’s a bit simplerread
in english is pronounced red
, but still spelled as read
!💪
https://github.com/Senmetsu/week2-npm Is this allright? 🤔