Listing assignment

[DanielvandeVelde]

Listing

I had a lot of fun with this one, but it was kind of difficult figuring stuff out. I couldn't finish everything in time, however I don't think I put all the necessary hours in. Like the list stuff would just be nearly the same for-loop that we also did in the learnyounode-assignment, but I really need my sleep to pay some attention during the class tomorrow.

Also, I should really look into the whole 'package.json' and '.gitignore' stuff. Seems like it would add something to my work.

A link to the thing can be found by clicking anywhere on this run-on sentence

[rijkvanzanten]

Hey @DanielvandeVelde!

I don't think I put all the necessary hours in

oh oh oh oh oh oh oh oh oh oh oh

I really need my sleep to pay some attention during the class tomorrow

I feel like @wooorm appreciates you being awake during class 😉

Also, I should really look into the whole 'package.json' and '.gitignore' stuff. Seems like it would add something to my work.

Yes!

Feedback

Repo

• Add installation / usage instructions to your readme so people who aren't familiar with your project know how to get the server up and running

Code

• Write your code comments in English, so people who read your code can also understand your comments
• Good job on the grouping of the different if statements. It makes the whole file nicely readable
• Most of the file is pretty redundant (DRY). You have the same two lines for every case. The content-type can be inferred from the extension in the URL (or lack there of, which would be the same as .html). The file that is being read by fs.createReadStream could potentially be inferred from the requested url. If you're up to the challenge and want to give it a shot, try merging all the if-statements in 1 block.

Functionality

• You request files using a relative path (./files/images/avatar.png). This causes the application to fail if it's started from another folder than the Server folder. For example, I started the app by running node Server/index.js
• You could improve the usability of the site by accepting both the path with and without a trailing /. For example, /assets works, but /assets/ doesn't.

I feel like you got the basics down pretty well. I'm looking forward to your submission for the shelter assignment!

[rijkvanzanten]

You could take a look at @MonikaaS' version, who coded the functionality in a way that it uses the url to fetch the files: https://github.com/MonikaaS/plain-server/blob/master/index.js