rijkvanzanten
commented
5 years ago Heya! This is looking pretty good so far 🙂
- I notice you have the same html in every single page ejs
<!DOCTYPE html> <html lang="en">You could add these two lines into your
headpartial so you don't have to repeat it in every page template - I'm not entirely sure what you're trying to do here: https://github.com/lennartdeknikker/dating-app-registration/blob/master/server.js#L5 but be careful with this kind of global state. This flag (true/false) is not specific to the user opening the page, but is global for the whole server. Keep that in mind while developing the functionality of your app.
- Same thing applies to the
idCounter, again i'm not totally sure what you're trying to achieve, but you're incrementing it everytime anyone accesses thechangeroute .listen()is asynchronous. You should use the callback function so the console log only shows up when the server is actually listening:
.listen(3000, function() { console.log('listening!'); });
Listing
Name
Lennart de Knikker
Class
212
Repo link
https://github.com/lennartdeknikker/dating-app-registration
Summary
I switched to developing another feature than I initially wanted to make. I'll build a feature to change or add information/interests to the users profile. This way it's easier to implement progressive enhancement and practice the stuff we learn.
Resources used
Any thoughts?
I got a little behind, because I couldn't really work with the feature I originally wanted to make and had to start over for a bit. I'm hoping to get back on track by the end of the week.