search

cmderdev / cmder

Lovely console emulator package for Windows
https://cmder.app
MIT License
25.88k stars 2.03k forks source link

hide update checks clink in CMD integration #2790

Closed candrapersada closed 1 year ago

candrapersada commented 1 year ago

Description

This commit will turn off the automatic checks for available updates when Clink starts up.

The purpose is to hide the annoying messages that appear on every new terminal tab, when the vendored Clink is outdated.

DRSDavidSoft commented 1 year ago

We should also turn off ConEmu updates, if clink's is off.

I'd feel comfortable merging this after we provide an auto update mechanism for Cmder and it's vendored dependencies.

candrapersada commented 1 year ago

what I mean is hide update checks clink in CMD image

daxgames commented 1 year ago

I think this should be configurable somehow. I actually like the clink auto update check feature and like the default.

Not going to merge this just yet.

daxgames commented 1 year ago

I think the default should be true here. and if the user wants to change it they can set it to false. That is how we do it for ConEmu

DRSDavidSoft commented 1 year ago

I'm going to close this, because:

  1. It's a good idea to regularly update Clink when there are newer versions.
  2. If a user doesn't want this, Clink has clear instructions on how to disable update checks right in the message.
  3. If we are going to disable auto-updates, I'd rather the settings be consistent with ConEmu also.

For reference, I personally do disable auto clink updates and ConEmu updates as well, because I don't like the upstream packages to be updated in front of Cmder, and I find the update messages annoying as well. But I'd prefer not to enforce this for all of the users.

Disabling auto updates globally might also pose some security risks. It's better if the user applies such configurations if they choose to do so.