Holding ^C made git.exe hang while cmd.exe (Clink) updated the prompt.
The prompt script had three problems:
It invoked git config every time a prompt was displayed, to figure out where to skip invoking git status. But it even did that if the current directory wasn't part of a git repo.
It invoked git config two times for every single prompt, to attempt to improve performance if the user disables git status coloring. But two times for every single prompt is expensive, so it has the opposite effect in the general case, and noticeably degrades performance.
It invoked git config using a blocking call, instead of using the async prompt support in Clink. That significantly reduced the benefit of having used async prompt filtering for git status.
Now the git config invocations use async prompt filtering, which lets the prompt display instantaneously. It also now uses a timer to avoid invoking git config repeatedly when new prompts show up in rapid succession.
Also, the cmderGitStatusOptIn variable is no longer leaked into the Lua global namespace.
These changes resolve the issue: holding ^C is very fast and no longer causes git.exe to hang.
DRSDavidSoft
commented
1 year ago
Holding ^C made git.exe hang while cmd.exe (Clink) updated the prompt.
The prompt script had three problems:
git configevery time a prompt was displayed, to figure out where to skip invokinggit status. But it even did that if the current directory wasn't part of a git repo.git configtwo times for every single prompt, to attempt to improve performance if the user disablesgit statuscoloring. But two times for every single prompt is expensive, so it has the opposite effect in the general case, and noticeably degrades performance.git configusing a blocking call, instead of using the async prompt support in Clink. That significantly reduced the benefit of having used async prompt filtering forgit status.Now the
git configinvocations use async prompt filtering, which lets the prompt display instantaneously. It also now uses a timer to avoid invokinggit configrepeatedly when new prompts show up in rapid succession.Also, the
cmderGitStatusOptInvariable is no longer leaked into the Lua global namespace.These changes resolve the issue: holding ^C is very fast and no longer causes git.exe to hang.