[Bug] Version meta information has not been updated in the 1.3.21 release

m2u-84 commented 1 year ago

Version Information

Cmder version: 1.3.21
Operating system: Windows 11 22H2 x64

Cmder Edition

Cmder Mini

Description of the issue

I just updated to the latest version (1.3.21) of the cmder Mini release and noticed, that the version info has not been raised. The version file in the ZIP root as well as the EXE meta info are still showing 1.3.20 for me (1.3.20.151 to be exact). I also checked the full version but it has the same issue. This is what I see with the latest files:

grafik

How to reproduce

Download latest full / mini release
Check “Version …” file → it is named incorrectly with the old version number
Open the Cmder.exe properties dialog in Windows → it is reporting the old version number as file and product version

Additional context

No response

Checklist

[X] I have read the documentation.
[X] I have searched for similar issues and found none that describe my issue.
[X] I have reproduced the issue on the latest version of Cmder.
[X] I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.

DRSDavidSoft commented 1 year ago

Thanks for reporting the bug! It appears that the packaged file was uploaded before making a git tag, which is our system for including the version file.

This is not a bug, but rather an accident made while publishing Cmder. We'll fix it by replacing the ZIP files with updated ones containing the right version info file.

Good catch!

Update: I believe we'll avoid editing the ZIP file and make a new release instead. For anyone interested, please read the follow-ups at: https://github.com/cmderdev/cmder/issues/2818#issuecomment-1648709904

daxgames commented 1 year ago

We should cut a new release so chocolatey can ingest the change. Otherwise you have to ask them to manually create a new package. Ask me how I know. 🤔

DRSDavidSoft commented 1 year ago

Hopefully if the package maintainers give us access, I can automate some parts so whenever a new version is released, it'll auto update on package managers

MartiUK commented 1 year ago

The current GitHub workflow doesn't build on tags, which may explain the mismatch.

daxgames commented 1 year ago

Simply replacing the zip files on a release cause the chocolatey issue. It is more of an issue with a functional bug fix less important here.

They trigger on a release creation.

chrisant996 commented 1 year ago

This is marked closed, but the issue still exists. Or at least, the files in the download link claim to be 1.3.20 (not .21).

DRSDavidSoft commented 1 year ago

@chrisant996 You're right, answered in the duplicate issue here:

https://github.com/cmderdev/cmder/issues/2818#issuecomment-1648709904

cmderdev / cmder