[Bug] Download Links on https://cmder.app point to the wrong versions.

cmderdev / cmder

Lovely console emulator package for Windows

https://cmder.app

MIT License

25.81k stars 2.02k forks source link

[Bug] Download Links on https://cmder.app point to the wrong versions. #2818

Closed daxgames closed 1 year ago

daxgames commented 1 year ago

Version Information

Cmder version:N/A
Operating system:N/A

Cmder Edition

Cmder Full (with Git)

Description of the issue

https://Cmder.app says links download 1.3.21 but they point to 1.3.20. Tried both full and mini.

How to reproduce

No response

Additional context

No response

Checklist

[X] I have read the documentation.
[X] I have searched for similar issues and found none that describe my issue.
[X] I have reproduced the issue on the latest version of Cmder.
[X] I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.

DRSDavidSoft commented 1 year ago

This is probably dupe of #2801, which if so, is already fixed in master

DRSDavidSoft commented 1 year ago

Confirmed that the link is correct, the package was misconfigured and it's solved in master. Closing this issue as in the next release the download link will contain correct version information

chrisant996 commented 1 year ago

Confirmed that the link is correct, the package was misconfigured and it's solved in master. Closing this issue as in the next release the download link will contain correct version information

But in the meantime, the site's download link still downloads files that claim to be 1.3.20 instead of 1.3.21. Since there is usually a long time between releases, why not update the link so that people can download the current version? Or re-release it with corrected version numbers? Or publish a 1.3.22 that doesn't have any new changes other than fixing the version number to be accurate? Otherwise it's a pretty confusing situation for users.

DRSDavidSoft commented 1 year ago

@chrisant996 I think the original idea was to avoid modifying an already existing release with new files to prevent hash mismatches, I'm not sure. But I also fully support releasing a minor build just to address this issue.

Additionally, I had mentioned the fact that there was an issue with the version file in the release description of v1.3.21. I'm open to making a new release myself, so asking either @MartiUK or @cmderdev/trusted-contributors to do so if needed. (Personally; I'd like to avoid making new releases myself and ask higher ups to do so, please 😉 )

Update: Looks like there is already a v1.3.24 being in draft state! 🎉 I wonder what happened to 1.2.22 and 1.3.23, though. 😄 So, hopefully, no need to fix 1.3.22, as I hope the note I added regarding version file inconsistency would suffice for future visitors.

If we are going to do so, I ask to wait a bit so some small improvements that are in the backlog can be finished as well.

DRSDavidSoft commented 1 year ago

@cmderdev/trusted-contributors @chrisant996

I believe due to the security concerns, it's a worthwhile effort to finalize the latest draft release made by @MartiUK. It shouldn't be in draft or pre-release state for this reason.

The v.1.3.24 is ready to be published since it uses the latest ConEmu package.