Open daxgames opened 1 year ago
@chrisant996 @DRSDavidSoft @pmsobrado Hopefully I captured the requirements. Let the solutioning begin!
Some thoughts:
..\opt\
directory or ..\bin\
directory above the non-Cmder profile directory.Thinking about it, I wonder if this is truly necessary since the new, yet to be merged, #2825 branch more_speed_2
gives the user total control over Clink injection. The user can edit the %CMDER_CONFIG_DIR%\user_init.cmd
to point to whatever Clink profile they want.
If we did decide to do this we would still need to process the %CMDER_ROOT%\vendor\clink.lua
and %CMDER_CONFIG_DIR%\cmder_prompt_config.lua
.
If we did decide to do this we would still need to process the
%CMDER_ROOT%\vendor\clink.lua
and%CMDER_CONFIG_DIR%\cmder_prompt_config.lua
.
Yes, i.e. Cmder would still need to use --scripts
.
Uh oh ... the code in Cmder's custom clink.lua doesn't work correctly for loading scripts from a user-specified profile directory in %CMDER_USER_CONFIG%
. It has a hard-coded assumption about where the config directory is, and it loads scripts from that hard-coded place.
So that would need to be changed as well.
Ah, it's a regression introduced in #1884 when fixing #1882. See here for details, and the code (and diffs) to fix the regression.
If I may interject, @chrisant996 why not make a PR since you already took the effort to write a fix and a patch 😅 Otherwise, @daxgames could you please apply it? Thank you to you both
If I may interject, @chrisant996 why not make a PR since you already took the effort to write a fix and a patch 😅 Otherwise, @daxgames could you please apply it? Thank you to you both
I can see where the question is coming from.
But, no, because:
I don't use Cmder. I constrain the time I spend on contributions to it. Obviously I spent a lot on this issue, but I've reached the end of what I'm willing to spend on it for a while.
In a few weeks if the issue hasn't been addressed yet, maybe I'll find time to work on it further.
Thanks for taking the time to investigate the issues and writing fixes. 🎉
I'll take what @chrisant996 did and verify and open a pr.
Suggestion
Cmder should somehow recognize if Clink is already injected and inherit the profile path instead of using
%CMDER_CONFIG_DIR%
.Use case
If Clink is injected globally on cmd, the history should available if using cmder while maintaining the the Cmder [rompt.
Extra info/examples/attachments
No response
Checklist