cmderdev / cmder

Lovely console emulator package for Windows

https://cmder.app

MIT License

25.86k stars 2.03k forks source link

clink.lua updates #2860

Closed daxgames closed 1 year ago

daxgames commented 1 year ago

Changes from #2856 and #2859

Adds

`%cmder_root%\vendor\clink.lua
- Comments to explain some of less than clear purpose of some code.
- Set global variable CMDER_CONFIG_PATH=%CMDER_ROOT%\config.
- Set global variable CMDER_USER_CONFIG_PATH to the value of env var '%CMDER_USER_CONFIG%' IF is is set else nil.
- Wrap gsub args 2 and 3 with verbatim()

daxgames commented 1 year ago

@chrisant996 I am not a lua dev so be gentle. :-)

I think I captured what you were talking about #2859 and #2856.

daxgames commented 1 year ago

WOW! I thought I understood, did not know it was possible to be so wrong. :-)

Closed this and will revisit.

chrisant996 commented 1 year ago

No worries! 😁

chrisant996 commented 1 year ago

@daxgames Oh, tell you what -- I will make a PR for the verbatim part.

While working on the git_prompt.lua change to use async prompt filtering, I realized there's more that needs to happen for the verbatim part. In the replace param only % needs to be escaped, but in the find param several other characters also need to be escaped.

I'll make a fix for git_prompt.lua slowness in clink-completions, and then I'll make a PR for the verbatim change in cmder.