daxgames commented 1 year ago

Windows Terminal Support

First looks at Windows Terminal Integration

NEED TO FIX

Command line help is for ConEmu only and needs to be updated.
Probably more.

NEED TO ADD:

Nothing that I know of.
Maybe more.

Progress So Far:

`Cmder.exe` Launcher:

Runs %cmder_root%\vendor\windows-terminal\WindowsTerminal.exe instead of ConEmu if %cmder_root%\vendor\windows-terminal exists.
Supports all existing command line arguments but /title, and /single.
Pass ALL arguments following -- argument directly to WindowsTerminal.exe to use the full power of Windows Terminal from the command line.
Modified Cmder.bat to launch windows terminal by default if it exists and put the default config file where it needs to be before launching Windows Terminal

Scripts:

Added an argument to build.ps1 that allows building with Windows terminal instead of Conemu.

Config:

Created a '%cmder_root%\vendor\WindowsTerminal_settings_default.json' that results in the WindowsTerminal Session and profiles shown above. NOTE: Non-Cmder sessions are auto-generated by Windows Terminal.
- All sessions work as they do today in Cmder using Conemu.
Changes to the word separator settings so it works more m=like we would expect it ti work.
Added Windows Terminal to %cmder_root%\vendor\sources.json

daxgames commented 1 year ago

We have downloadable Cmder with WIndows Terminal artifacts here

daxgames commented 1 year ago

This is a first stab at making a Windows Terminal integrated Cmder distribution.

It builds both Conemu and Windows Terminal Cmder archives.

I am 100% positive the launcher code could be better, but I am not a C++ developer. It works and that is an accomplishment in itself.

daxgames commented 1 year ago

I have been using Cmder in Windows Terminal exclusively for about a month and I just decided it was time to start this.

It was actually easier than I thought it would be.

daxgames commented 11 months ago

I identified an error with Windows terminal support and profiles set to run as Administrator. The %CMDER_ROOT% env var is not set and we have no way of figuring out what the root path for Cmder is on Administrative profiles.

I have requested a feature in Windows Terminal https://github.com/microsoft/terminal/issues/16295 that has the potential to resolve this the same way ConEmu does. Our init scripts could then look for %WT_FOLDER_PATH% the same way we do for %ConEmuDir%

MartiUK commented 10 months ago

I identified an error with Windows terminal support and profiles set to run as Administrator. The %CMDER_ROOT% env var is not set and we have no way of figuring out what the root path for Cmder is on Administrative profiles.

I have requested a feature in Windows Terminal microsoft/terminal#16295 that has the potential to resolve this the same way ConEmu does. Our init scripts could then look for %WT_FOLDER_PATH% the same way we do for %ConEmuDir%

Looks like it's slated for the WT 1.20 release, are you happy to wait or shall we try and find another solution?

daxgames commented 10 months ago

We can wait

daxgames commented 10 months ago

For those that want admin profiles before then you can set CMDER_ROOT globally via Windows env vars to fix the issue.

DRSDavidSoft commented 10 months ago

@daxgames I've merged this and the speed optimization PRs into development branch for testing purposes. So sorry it's taking this long to review, I'm still unimaginably busy with some projects and IRL issues, but I'm super eager to test these great additions and apply them in master soon. Hoping for a speedy Cmder 1.4 release!

daxgames commented 10 months ago

@DRSDavidSoft We can't really release 1.4 until https://github.com/microsoft/terminal/issues/16295 gets released.

DRSDavidSoft commented 4 months ago

@daxgames Why is the PR closed

cmderdev / cmder