cmderdev / cmder

Lovely console emulator package for Windows
https://cmder.app
MIT License
25.74k stars 2.02k forks source link

[Bug] lost git branch highlighting when there are modified files #2883

Closed TNSaturday closed 9 months ago

TNSaturday commented 9 months ago

Version Information

Cmder version: 1.3.20.151
Operating system: Windows 11 22H2

Cmder Edition

Cmder Full (with Git)

Description of the issue

Previous to todays (October 18) clink update I had nice yellow git branch highlighting, when there are modified files. Now it's gone.

How to reproduce

  1. Create empty folder, run git init inside to initialize new git repository.
  2. Run echo something > test.txt to create a file with come content in it.
  3. Run git add ., git commit -m "First commit" to commit changes.
  4. Modify test.txt file.
  5. No yellow highlighting of the branch name

Additional context

image

1 - pending changes in test.txt 2 - no syntax highlighting

Checklist

chrisant996 commented 9 months ago

I'll see if I can reproduce this locally.

Note: the report states this is caused by Clink. So it probably belongs in the Clink repo, and the fourth checkbox should be unchecked since it's almost certainly a Clink issue not a Cmder issue.

chrisant996 commented 9 months ago

I can reproduce the issue.

chrisant996 commented 9 months ago

This is not a Cmder issue. It is a Clink bug introduced in v1.5.10. A fix is coming.

chrisant996 commented 9 months ago

Clink v1.5.11 has been published with the fix.

This issue can be closed.

DRSDavidSoft commented 9 months ago

Thanks for the fix, @chrisant996.

@TNSaturday please upgrade clink in your Cmder again.