[Feature request] Update Clink version chrisant996 / v1.6.8

mattdkerr commented 4 months ago

Suggestion

Upgrade Clink to version chrisant996 / v1.6.8

Use case

Update for fixes/features, but also to prevent clink update reminders, which don't work properly anyway

Extra info/examples/attachments

https://github.com/chrisant996/clink

Checklist

[X] I have read the documentation and made sure this feature doesn't already exist.
[X] I have searched for similar issues and found none that describe my feature request.

chrisant996 commented 4 months ago

@mattdkerr I'm the maintainer of Clink. Can you please share more about "Clink update reminders don't work properly"? No one has reported anything like that in the Clink repo. Please include as many details as possible about what happens (or doesn't) and how to reproduce the problem.

Have you turned off Clink update notifications, but you're still getting them?
Are you getting update notifications but the update doesn't finish successfully?
Or is something else happening?

Please share details, and the clink.log file.

chrisant996 commented 3 months ago

@mattdkerr Can you share details about "Clink update reminders don't work properly"?

With more information, troubleshooting can happen, leading to a solution.

mattdkerr commented 3 months ago

I believe the built in clink update command (banner on shell open) installs to a system location instead of where cmder puts it.

chrisant996 commented 3 months ago

I believe the built in clink update command (banner on shell open) installs to a system location instead of where cmder puts it.

No: clink update installs to the location of the Clink program files that get executed.

However, if you have also installed Clink separately from Cmder, and have configured Clink for AutoRun, then there's probably an edge case involved:

In that case, BOTH copies of Clink are actively trying to work together. That would require updating BOTH copies of Clink.

What you should do to fix that complex configuration inter-dependency, is use clink autorun uninstall, and then use clink autorun install from inside Cmder. Then the Cmder copy is the one that will always get injected first, and then updating from inside Cmder will work.

It's not exactly a Clink issue, it's more of an issue with how Cmder tries to override Clink using an undocumented debugging switch.

I'll try to think about what could be done about that. Cmder does not expect you to install a second copy of Clink separately.

UPDATE:

But no, my earlier guess above doesn't seem accurate. I tried it, and everything seemed to work correctly, even with two copies of Clink installed (one standalone Clink installed to a separate location with AutoRun enabled, and a second Clink installed as part of Cmder).

@mattdkerr Can you please share:

The output from clink info inside Cmder.
How many copies of Clink you have installed, and what versions they are.
What goes wrong? What observation led to the statement "...clink update reminders, which don't work properly anyway"?

The guess about installing to a system location doesn't give me information to do troubleshooting (and isn't what happens).

chrisant996 commented 3 months ago

I believe the built in clink update command (banner on shell open) installs to a system location instead of where cmder puts it.

@mattdkerr in addition to my previous reply, can you please share details about what you do and what goes wrong? I appreciate the guess you shared, but to get to the bottom of what's really happening, it would help if information could be shared about what actually happens. I can't see it for myself, so I need more information to do troubleshooting.

(And in case it wasn't clear, the reason I'm asking is that I'm the maintainer of Clink, and no one has reported anything that sounds like this before in the Clink repo or Cmder repo.)

UPDATE:

@mattdkerr Here is the only thing I've been able to find:

If Clink is installed separately and configured for AutoRun and Cmder is also installed, then clink update updates whichever copy of Clink is configured for AutoRun. And that's expected and correct behavior.

And in that case, if one inspects the versions of the Clink files under the Cmder\vendor directory, then one will see older Clink version numbers. Which is also expected and correct behavior.

But that doesn't lead to any problems with clink update reminders: the copy configured for AutoRun is the copy that gets injected, and is the copy that gets updated. In that case, clink update reminders are working correctly and accurately.

So, I think you must be encountering something different, and to do troubleshooting about whatever you're experiencing, additional information is needed (also see my previous reply, which has specific questions).

mattdkerr commented 3 months ago

Please close this out, I'm not sure why it was happening but I can't repro it anymore

chrisant996 commented 3 months ago

Please close this out, I'm not sure why it was happening but I can't repro it anymore

@mattdkerr If you run into it again, please open an issue and include (1) the output from clink info, (2) the contents from the clink.log file (the location of the file is listed in the clink info output), and (3) a description of the steps and the results and output from them. Thanks!

cmderdev / cmder