[Bug] development builds `cmder.exe` always overwrites the terminal emulator settings files.

cmderdev / cmder

Lovely console emulator package for Windows

https://cmder.app

MIT License

25.69k stars 2.02k forks source link

[Bug] development builds `cmder.exe` always overwrites the terminal emulator settings files. #2940

Open 296951 opened 1 month ago

296951 commented 1 month ago

Version Information

Cmder version:development
Operating system:Windows 11

Cmder Edition

Development branch.

Description of the issue

Title says it all.

How to reproduce

Edit/Add a profile/task in Windows Terminal or ConEmu.
Close Windows Terminal or ConEmu
Run cmder.exe
Profile Edits/Adds are lost.

Additional context

No response

Checklist

[X] I have read the documentation.
[X] I have searched for similar issues and found none that describe my issue.
[X] I have reproduced the issue on the latest version of Cmder.
[X] I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.

daxgames commented 1 month ago

Working on it...

daxgames commented 1 month ago

I must have had an OLD Cmder.exe the currently compiled exe works fine.

DRSDavidSoft commented 1 month ago

So the profile creation is done using the launcher?

Quick q. would it also make sense to add the profile to the global WT itself in the mini versions as well... for people that don't want to include a duplicate WT on their machines BTW

daxgames commented 1 month ago

So the profile creation is done using a launcher?

Yes - Always has even for ConEmu

Cmder.exe copies a Default ConEmu.xml or a settings.json if they do not exist.

Quick q. would it also make sense to add the profile to the global WT itself in the mini versions as well... for people that don't want to include a duplicate WT on their machines BTW

I don't understand the question. The cmder-mini distributions include either ConEmu or Windows Terminal depending in which distro is downloaded.

UNRELEASED - Cmder for Windows is micro compared to mini as it does not include a terminal emulator and uses native Cmd.exe/Powershell.exe shells pre-installed with Windows or Git Bash.

See PR #2942

DRSDavidSoft commented 1 month ago

@daxgames "Micro" would be my pesonal favorite as it would include the core Cmder features (e.g. profiles & clink) and leave the terminal to the end-user

daxgames commented 1 month ago

@DRSDavidSoft Cmder for Windows is just that EXCEPT it uses Cmd.exe, Powershell.exe, and bash.exe or mintty.exe. There is ZERO configuration to say launch these in ConEmu or Windows Terminal or ANY other terminal emulator.

daxgames commented 1 month ago

This is worse than I originally thought. ConEmu is busted too.