search

cmdln / flashbake

Scripts to gather information for including in version history comments and to make using source control a bit simpler for non-technical projects.
GNU General Public License v3.0
456 stars 39 forks source link

Python 2 is being deprecated #36

Closed ElonSatoshi closed 3 years ago

ElonSatoshi commented 4 years ago

Might be a good idea to make this software work with python 3

brainwane commented 4 years ago

In March (prior to the 0.28 release), because this software depends on Python 2 and seemed unmaintained, Debian removed it from unstable. @cmdln would you be interested in other contributors helping port this software to Python 3?

brainwane commented 4 years ago

@abhidg heads-up about how Debian's tracker doesn't know about this year's release.

abhidg commented 4 years ago

@brainwane thanks, the tracker hasn't been updated to use github I think, if it's ported to Python 3, I will take a look at the packaging, it's been a while :)

cmdln commented 4 years ago

I am entirely open to anyone who wants to port Flashbake to Python 3. I haven't done any Python coding in years and am happy to grant permissions for anyone else willing to do this work.

brainwane commented 4 years ago

@cmdln ok, great, I'm gonna quickly see how big a job that looks like. Anything I should know about which branch to work off (in case I should be looking at something other than master) or any other development-process gotchas?

cmdln commented 4 years ago

No other branches and it has been so long, I don't recall any particular gotchas.

brainwane commented 4 years ago

I took about 30-45 minutes to familiarize myself with stuff and saw that it won't be a piece of cake for me (however, it's been years since I converted code from Python 2 to Python 3, so it's probably a lot faster for someone else). I created a work-in-progress pull request #39 -- I am not currently a user of flashbake and probably won't be for several weeks* so I don't know when or if I'll come back to it. Happy to add other users as collaborators on that fork so you can make more progress on the PR if anyone's interested. Or you can make your own PR of course!

* During my writing this month, I want to track daily wordcount, and it would be a little annoying to try to do that with flashbake's model of committing multiple times per hour; right now I'm instead committing once per day so I can use this approach to count my words written that day.

ianpaul commented 3 years ago

Whoops, sorry I didn't check the issues here before I started working.

I've got an active branch here: https://github.com/ianpaul/flashbake/tree/flashbake3.

Flashbake itself is now working in Python 3.

The Tests folder isn't working properly.

For plugins Feed, Weather, Uptime, Time Zone, and Time Stamp all work (as tested on WSL and Crostini). The rest haven't been tested yet. I don't plan on porting Identica or Growl as they are legacy plugins. Though perhaps Identica could be the basis of a new Mastodon plugin further down the line.

I'm working on this on the weekends and some weekday evenings if anyone wants to help.

ianpaul commented 3 years ago

Since the work is so far along now I've created a draft pull request here: https://github.com/cmdln/flashbake/pull/40 Anyone who wants to grab a plugin to modify it for Python 3 please do! The top comment in the PR describes what work still needs to be done.