cmdrmcdonald / EliteDangerousDataProvider

Apache License 2.0
133 stars 31 forks source link

EDDI companion API failure #179

Closed Stevax closed 7 years ago

Stevax commented 7 years ago

Just updated to latest version, now cannot link to Frontier API

capture
NicoFlows commented 7 years ago

+1 same problem same message

nfxus commented 7 years ago

+1 Same here!

ReverendRhyme commented 7 years ago

+1 Same issue capture

borranvrikel commented 7 years ago

same here

Estelyen commented 7 years ago

Same message in german: eddi

carlostib commented 7 years ago

Exactly same issue! I reinstalled EDDI cause I changed mobo so I'm reinstalling everything, and when I try to set the Companion App from EDDI, same message appears: eddi_companion_app_issue

bradsr132 commented 7 years ago

same here

Heisenberch commented 7 years ago

same here , but thanks for your work all the time !

The1AndMany commented 7 years ago

Same here.

Update: Just double-checked. EDDI 2.2.2 was released 2 days ago, and ED 2.3 just dropped (just finished downloading the update myself). This bug was first reported 4 hours ago, which suggests that while ED was still 2.2 it worked fine. Maybe there's some backend change in the Frontier API that broke things, rather than a problem with the EDDI update?

Darkcyde13 commented 7 years ago

EDDI wouldn't even load for me anymore. It started, I could see it in the Task Manager, but before the EDDI screen appeared, the whole thing just quit.

However, deleting my credentials.json, allows it to run again. And now I get the same error as everyone else.

vinman75 commented 7 years ago

Same here for me.

awp3rator commented 7 years ago

Same issues as above. I had another ticket open with full logging info in it. EDDI 2.2.2 Crash on Startup with Elite 2.3 Patch #180

SlashmanSG commented 7 years ago

Same here, sucks because I'm not playing ED without it.

folkdeezy commented 7 years ago

yeah cant get it to recognize me, now it wont even open

rhedrock commented 7 years ago

Same issue, same screenshot as the first post; here's what my Win10 event viewer had (Also, the app will not open again):

Application: EDDI.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: Microsoft.CSharp.RuntimeBinder.RuntimeBinderException at DynamicClass.CallSite.Target(System.Runtime.CompilerServices.Closure, System.Runtime.CompilerServices.CallSite, System.Object, System.String) at EddiCompanionAppService.CompanionAppService.ShipFromProfile(System.Object) at EddiCompanionAppService.CompanionAppService.ProfileFromJson(Newtonsoft.Json.Linq.JObject) at EddiCompanionAppService.CompanionAppService.ProfileFromJson(System.String) at EddiCompanionAppService.CompanionAppService.Profile(Boolean) at EddiCompanionAppService.CompanionAppService..ctor() at EddiCompanionAppService.CompanionAppService.get_Instance() at Eddi.MainWindow.setStatusInfo() at Eddi.MainWindow..ctor(Boolean) at Eddi.MainWindow..ctor()

Exception Info: System.Windows.Markup.XamlParseException at System.Windows.Markup.WpfXamlLoader.Load(System.Xaml.XamlReader, System.Xaml.IXamlObjectWriterFactory, Boolean, System.Object, System.Xaml.XamlObjectWriterSettings, System.Uri) at System.Windows.Markup.WpfXamlLoader.LoadBaml(System.Xaml.XamlReader, Boolean, System.Object, System.Xaml.Permissions.XamlAccessLevel, System.Uri) at System.Windows.Markup.XamlReader.LoadBaml(System.IO.Stream, System.Windows.Markup.ParserContext, System.Object, Boolean) at System.Windows.Application.LoadBamlStreamWithSyncInfo(System.IO.Stream, System.Windows.Markup.ParserContext) at System.Windows.Application.LoadComponent(System.Uri, Boolean) at System.Windows.Application.DoStartup() at System.Windows.Application.<.ctor>b__1_0(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.DispatcherOperation.InvokeImpl() at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object) at System.Windows.Threading.DispatcherOperation.Invoke() at System.Windows.Threading.Dispatcher.ProcessQueue() at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32) at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr) at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef) at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame) at System.Windows.Threading.Dispatcher.PushFrame(System.Windows.Threading.DispatcherFrame) at System.Windows.Application.RunDispatcher(System.Object) at System.Windows.Application.RunInternal(System.Windows.Window) at System.Windows.Application.Run(System.Windows.Window) at System.Windows.Application.Run() at Eddi.App.Main()

ErikLentz commented 7 years ago

Same issue.

rclough commented 7 years ago

+1

Loaded voice attack, complained it needed an upgrade, and to start EDDI standalone.

EDDI standalone would start, begin to say it needs an upgrade, then immediately crashing, making upgrading impossible.

Manually installed 2.2.2

EDDI now doesnt even appear to start. I could delete the credentials like others but it seems it will do no good.

geofwlkr commented 7 years ago

You must be tired of Me Too notices but Me Too...
I have just realised how much I rely on EDDI when in game.

Darkcyde13 commented 7 years ago

This would appear to be due to ED 2.3 Companion App changes. Until a new build of EDDI is released, deleting your %APPDATA%/Roaming/EDDI/credentials.json will allow EDDI to run again. However, there will be limited functionality. Don't try to log into the Companion App again, or you will have to delete the credentials.json again before EDDI will start the next time you try to run it.

Some people have attributed this problem to the new upgrade to Windows 10 Creators Update. However, I upgraded last week when it was first available to download from Microsoft, and both EDDI and ED2.2 worked perfectly on it, so I'm sure that the new Windows is not the cause.

geofwlkr commented 7 years ago

I can confirm that. I also had EDDI working happily with the new version of Windows 10. I had been using it when ED decided to close the servers, when the ED update eventually loaded the problems started.

Kraegge commented 7 years ago

I can confirm that it has nothing to do with the Windows update. I have the same problem since 2.3 went live, but have not yet updated Windows 10.

Robert-Laverick commented 7 years ago

I've done a little digging, looks like the companion API isn't providing json data for ships in quite the same way, a few minor changes as well as a lot of the information for stored ships being missing, which causes problems.

I've done a first pass at hacking the code to work with 2.3, and it's at least able to open now, though it means you can only export your current ship to coriolis exporting others causes errors, and I've not used it extensivly yet, things that depends on ship setup could be broken else where too.

https://github.com/Robert-Laverick/EliteDangerousDataProvider/commit/e10546e51a7a95971d63a6ca8487ddd2317492fa

GobleSt commented 7 years ago

EDDI broken here also.

It was working in the BETA. Currently VA shows the plugin initializing but it is not working and I am unable to open the companion app.

This is also broken but was broken in BETA, also throwing exceptions: https://github.com/Duke-Jones/ED-IBE
This is working: https://github.com/Marginal/EDMarketConnector/wiki

Windows 10 creators update.

Robert-Laverick commented 7 years ago

Looks like my patch is actually just a duplication of work, TomasEkeli beat me to it with a pull request that's doing more or less the same things (still learning how github works, apologies for the learning curve showing) https://github.com/cmdrmcdonald/EliteDangerousDataProvider/pull/186

I've tested a bit today and it does seem functional with these patches, though there are issues with ship exports for stored ships (active ones seem to be working, but I've not done exhaustive testing)

TomasEkeli commented 7 years ago

Until a new release is made you can drop in a replacement-file for the CompanionApp -library as described in the readme in this zip: https://www.dropbox.com/sh/kvevq3u9qbi9mm5/AAAHgcMdqmLh7sR4ZSbJOuQba?dl=0&preview=EDDI_commanders_fix.zip

geofwlkr commented 7 years ago

Unfortunately after dropping in the replacement file and restoring the credentials.json file EDDI does not crash but it no longer gives system detail when you make a jump. Also whenever EDDI would be expected to give some form of audio response the Elite game suddenly stutters (presumably fighting EDDI for processor time).

TomasEkeli commented 7 years ago

I've noticed that in the last few hours as well, @geofwlkr, but that's not this. It's been working fine for me for over 24 hours with the replacement. I suspect some other service has either changed their output or gone down. I'll look into it, I think - but I don't know what causes it.

mikelimtw commented 7 years ago

You know, I'm kind of surprised CmdrMcDonald hasn't weighed in on this yet

cmdrmcdonald commented 7 years ago

Apologies for the delay in providing a fix for this, I will address this issue today. Please note that this due to undocumented changes in the Frontier API the following features will no longer be available:

Some of these items can be obtained in a different way to that how they are obtained today, and will be reinstated in a future patch.

mikelimtw commented 7 years ago

I'm sort of surprised that FDev keeps doing this... making undocumented changes when there is such a huge community basically working for free to support them to make money. Anyway, thank you for your hard work on EDDI. I got a rude awakening when EDDI stopped working and I saw how much atmosphere this plugin provided to the game. I can't play Elite any other way now. :P

Stevax commented 7 years ago

I think everyone realises it's down to Fdev end changes, I just think the amount of people logging the problem shows how popular your app is, I certainly miss it. Thanks for looking at it.

Sent from my iPad

On 14 Apr 2017, at 07:28, cmdrmcdonald notifications@github.com wrote:

Apologies for the delay in providing a fix for this, I will address this issue today. Please note that this due to undocumented changes in the Frontier API the following features will no longer be available:

engineer modifications when exporting to Coriolis ability to export stored ships to Coriolis information about the total and current amounts of fuel information about the total and current amounts of cargo Some of these items can be obtained in a different way to that how they are obtained today, and will be reinstated in a future patch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

cmdrmcdonald commented 7 years ago

This issue should be addressed with EDDI 2.2.3. You can obtain this using the usual upgrade method or you can obtain it directly from https://www.mcdee.net/elite/EDDI.exe

Darkcyde13 commented 7 years ago

Logs in fine for me now. Thank you Cmdr. McDonald!

geofwlkr commented 7 years ago

Magic! No problems, no stuttering and audio information restored. Thanks Cmdr.McDonald!

jimbot70 commented 7 years ago

Thank you for all of your work on this CMDR McDonald.

rj16066 commented 7 years ago

Thank you for the quick fix... Cheers