search

cmdrmcdonald / EliteDangerousDataProvider

Apache License 2.0
133 stars 31 forks source link

Beta bug: Shipyard ship names #205

Closed Tkael closed 7 years ago

Tkael commented 7 years ago
  1. Spaces are removed from the ship names in the shipyard.
  2. IPA phonetic pronunciations do not seem to override the default pronunciation.
Tkael commented 7 years ago

Example: my ship is named "The Windblown Leaf" The shipyard registers the name as "thewind****nleaf" Pronunciation is butchered. Trying to add IPA to the Name (spoken) field does not change the pronunciation (even using the example IPA "praɪdɒvˈakɜːnɑ").

cmdrmcdonald commented 7 years ago

Please could you send me your journal for the time at which you named your ship so that I can see what information is provided to EDDI from Elite?

Regarding the IPA pronunciation, what is the situation in which you are hearing the ship name, and can you confirm that you have phonetic speech enabled in the EDDI's text to speech tab?

Tkael commented 7 years ago

Here you go. Oddly, the journal seems to have it right even though the shipyard has it wrong.

{ "timestamp":"2017-04-19T04:53:38Z", "event":"SetUserShipName", "Ship":"asp", "ShipID":6, "UserShipName":"the windblown leaf", "UserShipId":"TK-19A" }

Journal.170418195557.01.zip

Shipyard.zip

Note also that the Imperial Courier and Imperial Clipper are being rendered as 'Empire_Courier' & 'Empire_Trader' respectively.

cmdrmcdonald commented 7 years ago

The shipyard looks corrupted to me. Please could you shut down EDDI, remove the %APPDATA%\shipmonitor.json file, and restart EDDI? You'll need to swap in to your ships for EDDI to pick up the data but after that it should behave.

It's possible that the corruption is due to multiple attempts to update the ship data at the same time, so I've altered the code to lock the shipyard prior to updating it. I'll make a beta 4 release, hopefully later today, which should fix the problem permanently.

cmdrmcdonald commented 7 years ago

Beta 4 of EDDI has just been released which should avoid this issue. It avoid using any names that might have been filtered when updating local ship information, in addition to the shipyard locking that should remove corruption issues. Please let me know if you encounter this issue again.

Tkael commented 7 years ago

Confirmed as fixed. An additional observation of beta 4/5 behavior: Switching to and from "the Windblown Leaf" did not update the name in the shipyard, though renaming the ship in livery did update the shipyard.