cmdrmcdonald / EliteDangerousDataProvider

Apache License 2.0
133 stars 31 forks source link

StarSystem "Col 285 Sector GM-V d2-83" returns only 3 bodies - EDDP.CO out of sync? #266

Open panzertard opened 7 years ago

panzertard commented 7 years ago

I've been tracking why I've had some issues getting correct number of bodies (exlcuding belts) for a system when I jump there. Seems EDDP.CO may be out of sync

Problem: http://api.eddp.co/systems/Col%20285%20Sector%20GM-V%20d2-83 Returns 3 bodies only.

https://www.edsm.net/en/system/bodies/id/44477/name/Col+285+Sector+GM-V+d2-83 Returns correctly all 29 bodies. (not including belts)

It would be nice to be able to chose which backend URI where to request data from. However I can see the implication of such a request. The modelling schema may not be the same, although I have a sneaking suspicion that we have similar modelling for all the data-providers these days?

Anyway, I need to have updated and correct number of bodies returned, otherwise I'm back to doing manual HTTP lookups. EDDI solves this very nicely only if the data was correct. :)

The request from the logs: 2017-08-05T14:36:26 Net:GetResponse [D] Requesting http://api.eddp.co/systems/Col 285 Sector GM-V d2-83 2017-08-05T14:36:26 Net:GetResponse [D] Response is {"m_HttpResponseHeaders":["Content-Encoding","Vary","Content-Length","Content-Type","Date"],"m_Uri":"http://api.eddp.co/systems/Col%20285%20Sector%20GM-V%20d2-83","m_Certificate":null,"m_Version":{"Major":1,"Minor":1,"Build":-1,"Revision":-1,"MajorRevision":-1,"MinorRevision":-1},"m_StatusCode":200,"m_ContentLength":-1,"m_Verb":"GET","m_StatusDescription":"OK","m_MediaType":null} 2017-08-05T14:36:26 Net:DownloadString [D] Reading response 2017-08-05T14:36:26 Net:DownloadString [D] Data is: {"id":45985,"name":"Col 285 Sector GM-V d2-83","x":-151.65625,"y":1.65625,"z":-174.5625,"population":0,"is_populated":false,"government":"None","allegiance":"None","state":"None","security":"Low","primary_economy":"None","updated_at":1493662999,"bodies":[{"created_at":1488040217,"group_id":3,"group_name":"Belt","id":3063377,"is_landable":0,"is_rotational_period_tidally_locked":false,"name":"Col 285 Sector GM-V d2-83 A A Belt","ring_inner_radius":1546900,"ring_mass":40002000000000,"ring_outer_radius":2477300,"ring_type_id":3,"ring_type_name":"Metallic","system_id":45985,"updated_at":1493040572},{"age":770,"arg_of_periapsis":6.154089,"created_at":1488040217,"distance_to_arrival":0,"group_id":2,"group_name":"Star","id":3063378,"is_landable":0,"is_main_star":true,"is_rotational_period_tidally_locked":false,"name":"Col 285 Sector GM-V d2-83 A","orbital_eccentricity":0.201119,"orbital_inclination":-53.135475,"orbital_period":513345159168,"rotational_period":4.917198712384259,"semi_major_axis":358.9037111746003,"solar_masses":1.082031,"solar_radius":1.1397783642374586,"spectral_class":"F","surface_temperature":6138,"system_id":45985,"updated_at":1500504633},{"arg_of_periapsis":186.441727,"created_at":1489852653,"distance_to_arrival":584.824402,"earth_masses":6.529394,"gravity":2.4950881289737,"group_id":6,"group_name":"Planet","id":3585965,"is_landable":false,"is_rotational_period_tidally_locked":false,"name":"Col 285 Sector GM-V d2-83 A 1","orbital_eccentricity":0.000051,"orbital_inclination":0.003039,"orbital_period":38466496,"radius":10313.067,"rotational_period":1.5167924443055556,"semi_major_axis":1.1720393318138318,"surface_pressure":7187.706252158895,"surface_temperature":1774.534668,"system_id":45985,"terraforming_state_id":1,"terraforming_state_name":"Not terraformable","type":"High metal content world","type_id":30,"type_name":"High metal content world","updated_at":1494535979,"volcanism":{"amount":"Major","composition":"Silicate vapour","type":"Geysers"},"volcanism_type_id":8,"volcanism_type_name":"Silicate vapour geysers"}],"stations":[]} 2017-08-05T14:36:27 StarSystemSqLiteRepository:insertStarSystem [D] Creating new starsystem Col 285 Sector GM-V d2-83

Tkael commented 7 years ago

www.eddb.io is also returning correct information. https://eddb.io/system/bodies/45985