cmdrootaccess / another-flushbar

A flexible widget for user notification. Customize your text, button, duration, animations and much more. For Android devs, it is made to replace Snackbars and Toasts.
https://pub.dev/packages/another_flushbar
MIT License
145 stars 89 forks source link

Flutter 3 Upgrade #65

Closed beaurepair closed 2 years ago

beaurepair commented 2 years ago

Package is incompatible with Flutter 3's changes to null-aware operations.

../../Library/Flutter/flutter/.pub-cache/hosted/pub.dartlang.org/another_flushbar-1.10.28/lib/flushbar.dart:350:22: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null. [ ] - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../Library/Flutter/flutter/packages/flutter/lib/src/scheduler/binding.dart'). [ ] SchedulerBinding.instance!.addPostFrameCallback(

RichardGuesso commented 2 years ago

I have this problem too. In Flutter 3.0 image

I removed the question mark in the flushbar.dart class and the error is gone. Hope the team fixes it. image image

is that with the new version of flutter now the instance cannot come nulla anymore. This is just a warning.

X-SLAYER commented 2 years ago

i made a PR that resolve this pull#66

you can use this until the next update

another_flushbar:
  git:
    url: git@github.com:X-SLAYER/another-flushbar.git
panuplanet commented 2 years ago

image

Why can't I use it?

X-SLAYER commented 2 years ago

use https like that

another_flushbar:
  git:
    url: https://github.com/X-SLAYER/another-flushbar.git
labaxter commented 2 years ago

This is affecting me too. Creating comment to (hopefully) get notified when this is fixed.

RoyalCoder88 commented 2 years ago

same problem here

Jake-Duncan commented 2 years ago

I also am seeing this issue.

Jake-Duncan commented 2 years ago

For what its worth, this doesn't appear to be causing any issues in functionality, though I am seeing the same warning message. I just tested in iOS and android and I am seeing the Flushbars appear as expected.

cmdrootaccess commented 2 years ago

this is addressed in main branch

stayallive commented 2 years ago

Thanks @X-SLAYER and @cmdrootaccess 💪