Larger witness data (ordinal inscription) lead to OP_SUCCESSx rejection

cmdruid / tapscript

A humble library for working with Tapscript and Bitcoin Transactions.

https://www.npmjs.com/package/@cmdcode/tapscript

Creative Commons Zero v1.0 Universal

188 stars 49 forks source link

Larger witness data (ordinal inscription) lead to OP_SUCCESSx rejection #19

Closed BennyTheDev closed 10 months ago

BennyTheDev commented 11 months ago

In the latest version, creating inscriptions leads to push rejections on OP_SUCCESSx (tested in browser). Version 1.2.7 works normally.

Script.decode() on the raw tx errors as well (string length exceeded).

Sample asm from bitcoin-cli decodescript:

cmdruid commented 11 months ago

I will take a look at this. It looks like it may be a simple parsing error.

martianatwork commented 11 months ago

@cmdruid did you get time to check this issue?

cmdruid commented 11 months ago

I apologize, I have not had the time to take a look into this. I am working on meeting a deadline at the end of this month.

I should have more time beginning of next month. There's a new version of tapscript ready to release, just need to update the documentation.

rohitkeshav27 commented 10 months ago

Hey man Got this error

non-mandatory-script-verify-flag (OP_SUCCESSx reserved for soft-fork upgrades)

cmdruid commented 10 months ago

I apologize for the delay. This should be fixed in 1.4.3. Please feel free to re-open this issue if you are still having the same problem in the new version.