Closed chrisjonesBSU closed 7 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Ok, I added MacOS to the os matrix now.
Also, I made a separate jobs for testing the tutorials. I don't think we need to test the tutorials on every os + python version combo. Also, it should be set up so that the tutorial test has to be trigged manually with a comment in the PR. My thinking is that we can run that check once a PR is nearly finished, rather than having it run after every commit.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.40%. Comparing base (
9f0cda5
) to head (9d5a5c7
).
run-test-tutorials
run-test-tutorials
run-test-tutorials
/testtutorials
Hmm..I can't figure out how to trigger the pytest / test-tutorials
check with a comment.
/testtutorials
/testtutorials
/testtutorials
/testtutorials
testtutorials
/testtutorials
Ok, we're merging this as is for now. After talking with @marjanalbooyeh we are going to get a workflow set up to run test on notebooks locally or on clusters.
This PR adds
nbmake
toenvironment-dev.yml
and adds an action for testing the tutorial notebooks anytime a PR is made.The addition of this workflow and use of
nbmake
seems to be working as intended, but some of the notebooks have errors. I'll work on fixing those in this same PR.