JimmyRushing commented 3 years ago

added combine = True. the system.py becuase I got a no variable called "combine" error. with these three changes the p3ht workflow works.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 3 years ago

Codecov Report

Merging #18 (49152f6) into master (b71400b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files           9        9           
  Lines         766      766           
=======================================
  Hits          649      649           
  Misses        117      117

Impacted Files	Coverage Δ
morphct/system.py	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9b3b34...49152f6. Read the comment docs.

JimmyRushing commented 3 years ago

system.py change to try to fix this error Screen Shot 2021-07-06 at 3 15 42 PM

cmelab / morphct

Fixed two typos in examples/workflow-p3ht.ipynb. Added combine = True #18

Codecov Report