search

cmelab / morphct

GNU General Public License v3.0
0 stars 6 forks source link

not sorting msd_stderrs when sorting msds #20

Open jennyfothergill opened 3 years ago

jennyfothergill commented 3 years ago

https://github.com/cmelab/morphct/blob/d1bd1fc5d0e5b66c41ca03ae6f95c81d98a2f66a/morphct/kmc_analyze.py#L1919 Also do we need to calculate the lifetime error since it is guaranteed to be 0?

erjank commented 3 years ago

For longer values of lifetime this may not be true: There's also a cutoff after a certain number of moves (10K?), which may happen before lifetime is reached.

jennyfothergill commented 3 years ago

I will double check but I think currently the function is using the user provided lifetime--a single value with no error--and not the actual lifetime of the carrier.