JimmyRushing commented 2 years ago

This version of morphct is currently working for large morphologies and it is working on fry. The main change is the p.join deletion. Other changes may be vestigial changes made along the way.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 2 years ago

Codecov Report

Merging #35 (13c9cf0) into master (31ddf26) will decrease coverage by 4.91%. The diff coverage is 2.08%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   84.98%   80.07%   -4.92%     
==========================================
  Files           9       10       +1     
  Lines         766      813      +47     
==========================================
  Hits          651      651              
- Misses        115      162      +47

Impacted Files	Coverage Δ
morphct/chromophores.py	`94.69% <ø> (ø)`
morphct/kmc_analyze.py	`77.27% <ø> (ø)`
morphct/system.py	`0.00% <ø> (ø)`
p3ht-analysis-script.py	`0.00% <0.00%> (ø)`
morphct/mobility_kmc.py	`90.15% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31ddf26...13c9cf0. Read the comment docs.

cmelab / morphct

Multiprocessing fix for large runs #35

Codecov Report