search

cmelab / planckton

Reproducible exploration of organic photovoltaic morphology self-assembly using molecular dynamics.
GNU General Public License v3.0
5 stars 6 forks source link

Set up caching for docker images #23

Closed jennyfothergill closed 3 years ago

jennyfothergill commented 3 years ago

This issue is to help set up a testing system for future PRs that modify the environment. From discussion with Mike:

We should have some caching so that if the docker file and the environment.yml haven't changed, then we just use the docker image we have on the hub, if the files have changed, then we build a new image. Then after the PR is merged, that new image should be pushed to the hub.

I think then we might want to switch to using the "latest" image when testing, and then for versioning docker images, we should create separate PRs where we also tag planckton releases. I'll figure out how to do this and in the mean time we can do what are are doing to manually build docker images when we need to test new dependencies.

jennyfothergill commented 3 years ago

This first bit is fixed by the "paths" trigger in our build workflows

The second bit is covered by #41