cmelab / polybinder

Initialization of thermoplastic polymer systems to simulate thermal welding
GNU General Public License v3.0
2 stars 5 forks source link

Install mbuild from anaconda rather than my fork #24

Closed chrisjonesBSU closed 3 years ago

chrisjonesBSU commented 3 years ago

The environment.yml file was using a branch on my fork of mbuild to fix the particle out of box issues. The latest version of mbuild contains a PR that fixes the issue, so the environment file now installs mbuild from anaconda rather than my fork.

Also, having pip install the GAFF-foyer repo from the environment.yml file was causing a few issues. First, I think it was why foyer defaulted to using the .xml file that didn't have SMARTS definitions which caused the ff.apply() step to error out. Second, it didn't work with the latest version of pip (for reasons beyond my understanding). So, for now the fix is to install GAFF-foyer in a separate step which is outlined in the README.md file. We can revisit it later if we want to incorporate it back into the environment file for the sake of making the environment set up as simple as possible.

Addresses #21