cmelab / polybinder

Initialization of thermoplastic polymer systems to simulate thermal welding
GNU General Public License v3.0
2 stars 5 forks source link

Using kcal/mol and ang; added tests for conversions and base units #40

Closed chrisjonesBSU closed 3 years ago

chrisjonesBSU commented 3 years ago

In a previous PR I changed some of the temperature conversion functions to use kcal/mol and ang_to_m as they should be, but I forgot to add these to base_units.py. This PR fixes that issue as well as creating some unit tests for the functions in unit_conversion.py as well as a double-check of the conversion factors used in base_units.py

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (d7cead6) into master (a294d56) will increase coverage by 4.42%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   82.87%   87.30%   +4.42%     
==========================================
  Files           6        6              
  Lines         438      441       +3     
==========================================
+ Hits          363      385      +22     
+ Misses         75       56      -19     
Impacted Files Coverage Δ
uli_init/utils/unit_conversions.py 100.00% <ø> (+100.00%) :arrow_up:
uli_init/utils/base_units.py 100.00% <100.00%> (ø)