Closed RainierBarrett closed 2 years ago
Merging #48 (e94e8dc) into master (cf398bc) will decrease coverage by
0.80%
. The diff coverage is76.19%
.
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 93.95% 93.15% -0.81%
==========================================
Files 6 6
Lines 480 482 +2
==========================================
- Hits 451 449 -2
- Misses 29 33 +4
Impacted Files | Coverage Δ | |
---|---|---|
uli_init/simulate.py | 92.10% <54.54%> (-2.34%) |
:arrow_down: |
uli_init/system.py | 92.85% <100.00%> (+0.16%) |
:arrow_up: |
Looks good to me. I think we just need to remove the Gaussian unit test at the bottom of test_systems.py
@RainierBarrett Did you see my comment about removing the Gaussian unit test?
Also, if this PR is going to merge in the branch of another open PR, maybe it would make more sense, and be a lot easier to keep track of everything if we close one of them, and only have one PR.
Addresses #23, at least for now. Worth thinking about how big of the edge effect converting samples of 0 to 1 really has.