cmelchior / realmfieldnameshelper

Realm extension library used to create more type-safe queries.
Apache License 2.0
173 stars 21 forks source link

Fix for hungarian notation field name formatting #7

Closed jonasrottmann closed 8 years ago

jonasrottmann commented 8 years ago

This PR addresses issue #6

The check for hungarian notation Character.isUpperCase(currentCodepoint) && !Character.isUpperCase(previousCodepoint) && previousCodepoint == 'm' doesn't consider the 'm' to be the fist letter. In the example of issue #6 itemQuantityDelta the 'm' with the following 'Q' has been detected as hungarian and the first letter 'i' was mistakenly removed.

What I changed:

cmelchior commented 8 years ago

Nice, thanks 👍

cmelchior commented 8 years ago

Hi @jonasrottmann Thanks. 1.1.0 has been released with this fix.