Update yt-dlp from 2024.4.9 to 2024.7.1 [SECURITY]

renovate[bot] commented 3 months ago

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
yt-dlp	`==2024.4.9` -> `==2024.7.1`

:warning: This is a minor update.

GitHub Vulnerability Alerts

CVE-2024-38519

Summary

yt-dlp does not limit the extensions of downloaded files, which could lead to arbitrary filenames being created in the download folder (and path traversal on Windows). Since yt-dlp also reads config from the working directory (and on Windows executables will be executed from the yt-dlp directory) this could lead to arbitrary code being executed.

Patches

yt-dlp version 2024.07.01 fixes this issue by whitelisting the allowed extensions. This means some very uncommon extensions might not get downloaded; however, it will also limit the possible exploitation surface.

Workarounds

It is recommended to upgrade yt-dlp to version 2024.07.01 as soon as possible, always have .%(ext)s at the end of the output template, and make sure you trust the websites that you are downloading from. Also, make sure to never download to a directory within PATH or other sensitive locations like your user directory, system32, or other binaries locations.

For users not able to upgrade:

Make sure the extension of the media to download is a common video/audio/sub/... one
Try to avoid the generic extractor (--ies default,-generic)
Keep the default output template (-o "%(title)s [%(id)s].%(ext)s)
Omit any of the subtitle options (--write-subs, --write-auto-subs, --all-subs, --write-srt)
Use --ignore-config --config-location ... to not load config from common locations

Details

One potential exploitation might look like this:

From a mimetype we do not know, we default to trimming the leading bit and using the remainder. Given a webpage that contains

<script type="application/ld+json">
{
    "@&#8203;context": "https://schema.org",
    "@&#8203;type": "VideoObject",
    "name": "ffmpeg",
    "encodingFormat": "video/exe",
    "contentUrl": "https://example.com/video.mp4"
}
</script>

this will try and download a file called ffmpeg.exe (-o "%(title)s.%(ext)s). ffmpeg.exe will be searched for in the current directory, and so upon the next run arbitrary code can be executed.

Alternatively, when engineering a file called yt-dlp.conf to be created, the config file could contain --exec ... and so would also execute arbitrary code.

Acknowledgement

A big thanks to @JarLob for independently finding a new application of the same underlying issue. More can be read about on the dedicated GitHub Security Lab disclosure here: Path traversal saving subtitles (GHSL-2024-090)

References

Release Notes

yt-dlp/yt-dlp (yt-dlp)

### [`v2024.7.1`](https://togithub.com/yt-dlp/yt-dlp/compare/2024.05.27...2024.07.01) [Compare Source](https://togithub.com/yt-dlp/yt-dlp/compare/2024.05.27...2024.07.01) ### [`v2024.5.27`](https://togithub.com/yt-dlp/yt-dlp/compare/2024.05.26...2024.05.27) [Compare Source](https://togithub.com/yt-dlp/yt-dlp/compare/2024.05.26...2024.05.27) ### [`v2024.5.26`](https://togithub.com/yt-dlp/yt-dlp/compare/2024.04.09...2024.05.26) [Compare Source](https://togithub.com/yt-dlp/yt-dlp/compare/2024.04.09...2024.05.26)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

cmenon12 commented 3 months ago

Added commits from #122 and #123

renovate[bot] commented 3 months ago

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

cmenon12 / birdbox-livestream