search

cmfcmf / docusaurus-search-local

Offline / Local Search for Docusaurus v2. Try it live at:
https://cmfcmf.github.io/OpenWeatherMap-PHP-API/
MIT License
438 stars 67 forks source link

Add fix for docs only mode #25

Closed Techassi closed 3 years ago

Techassi commented 3 years ago

Fixes #21

cmfcmf commented 3 years ago

Thank you for this PR :+1: I've now looked into this bug myself and might have found a different solution that involves setting the existing docsRouteBasePath plugin option to /. After fixing a bug that occurred when setting the option to just / in https://github.com/cmfcmf/docusaurus-search-local/commit/e76534bfa394a85211baceea949ed9cf0600e101, docs-only mode should work just fine when passing { docsRouteBasePath: '/' } as options. Could you verify whether setting { docsRouteBasePath: '/' } in conjunction with e76534bfa394a85211baceea949ed9cf0600e101 fixes the problem for you? If so, I'd then go ahead and release v0.4.1. I have released version 0.5.0 that includes the fix.

cmfcmf commented 3 years ago

Also notifying @franciscojaramillo - see my comment above, the problem should be fixed in version 0.5.0 when correctly setting the docsRouteBasePath.

Techassi commented 3 years ago

Will check it out!

Techassi commented 3 years ago

Works without any problems. Closing. Thank you @cmfcmf

franciscojaramillo commented 3 years ago

Awesome, ty!