search

cmgriffing / bun-orb

An Orb for running Bun in CircleCI
MIT License
5 stars 1 forks source link

Bug: hard coded node version #1

Closed ndelangen closed 5 months ago

ndelangen commented 5 months ago

Is there an existing issue for this?

Orb version

cmgriffing/bun-orb@0.0.28

Current behavior

I have setup my runner to un in:

    docker:
      - image: cimg/node:18.19.1

But then this orb hard-codes install node version 18.17.1. See CI run here: https://app.circleci.com/pipelines/github/storybookjs/storybook/77470/workflows/ea284d06-93d2-4ff9-ad48-5fa1baa358c3/jobs/664099/parallel-runs/0?filterBy=ALL

Relevant log:

=> Installing Node.js version 18.19.1
Downloading and installing node v18.19.1...
Downloading https://nodejs.org/dist/v18.19.1/node-v18.19.1-linux-x64.tar.xz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums matched!
Now using node v18.19.1 (npm v10.2.4)
Creating default alias: default -> 18.19.1 (-> v18.19.1 *)
=> Node.js version 18.19.1 has been successfully installed
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
Downloading and installing node v18.17.1...
Downloading https://nodejs.org/dist/v18.17.1/node-v18.17.1-linux-x64.tar.xz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums matched!
Now using node v18.17.1 (npm v9.6.7)
default -> 18.17.1 (-> v18.17.1 *)

I have a .nvmrc file that's getting ignored.

You can compare this run which IS using the orb: https://app.circleci.com/pipelines/github/storybookjs/storybook/77470/workflows/ea284d06-93d2-4ff9-ad48-5fa1baa358c3/jobs/664099/parallel-runs/0?filterBy=ALL

With this one, which is NOT using the orb: https://app.circleci.com/pipelines/github/storybookjs/storybook/77460/workflows/e39379f0-0831-4402-9a27-18eb764bc9e6/jobs/664063

Here's the link to the circleci config file: https://github.com/storybookjs/storybook/blob/4ac11acaeee817cc2d26dc47da824a28169d172b/.circleci/config.yml#L337-L379

Minimum reproduction config

Complete config file: https://github.com/storybookjs/storybook/blob/4ac11acaeee817cc2d26dc47da824a28169d172b/.circleci/config.yml#L1-L839

Failing run: https://app.circleci.com/pipelines/github/storybookjs/storybook/77470/workflows/ea284d06-93d2-4ff9-ad48-5fa1baa358c3/jobs/664099/parallel-runs/0?filterBy=ALL

Other

No response

ndelangen commented 5 months ago

see: https://github.com/cmgriffing/bun-orb/blob/main/src/commands/setup.yml#L11