search

cmheisel / nose-xcover

Fork of nose.plugins.cover that enables XML output (for use with Hudson, e.g.)
MIT License
52 stars 17 forks source link

Python 3 support #14

Closed ojii closed 10 years ago

ojii commented 12 years ago

Under Python 3.1 and Python 3.2 this plugin fails:

Downloading/unpacking nosexcover
  Using download cache from /var/lib/jenkins/.pipcache/http%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fn%2Fnosexcover%2Fnosexcover-1.0.7.tar.gz
  Running setup.py egg_info for package nosexcover
    Traceback (most recent call last):
      File "/var/lib/jenkins/jobs/pymaging/workspace/python/python3.2/env/build/nosexcover/setup.py", line 4, in <module>
        desc = file.read(open('README.rst'))
    NameError: name 'file' is not defined

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 14, in <module>
      File "/var/lib/jenkins/jobs/pymaging/workspace/python/python3.2/env/build/nosexcover/setup.py", line 5, in <module>
        except StandardError:
    NameError: name 'StandardError' is not defined
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "/var/lib/jenkins/jobs/pymaging/workspace/python/python3.2/env/build/nosexcover/setup.py", line 4, in <module>

    desc = file.read(open('README.rst'))

NameError: name 'file' is not defined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

  File "<string>", line 14, in <module>

  File "/var/lib/jenkins/jobs/pymaging/workspace/python/python3.2/env/build/nosexcover/setup.py", line 5, in <module>

    except StandardError:

NameError: name 'StandardError' is not defined
msabramo commented 11 years ago

I also am seeing that installing from PyPI (nosexcover-1.0.7; released 2011-09-06) fails in Python 3.

However, the latest version on GitHub appears to be fixed. I have been doing pip install git+https://github.com/cmheisel/nose-xcover.git@0a1185fbf8348a7c5312e5ada943de26ce2a3840 to work around the problem.

It would be nice to release a new version to PyPI so that Python 3 users can do a simple pip install and have it work.

duly commented 10 years ago

We may assist with the Python 3 compatibility after our pyjs conversion has completed.

msabramo commented 10 years ago

I think Python 3 support is working now and this can be closed?

cmheisel commented 10 years ago

This should be working as of 1.0.10 and 7755ade2bbab1139263e4e5e966c264cd07498df