Cannot add specialties

[korey-enright]

When trying to add a specialty, it appears to do nothing. Nothing shows up on the edit page after clicking add, however on save it looks like there is a phantom specialty. When loading up the edit page again after saving, the phantom specialty does show up, and can be deleted. However it cannot be made to reflect the values of the specialty fields in the form.

However, when a new edit session is created, and an Academics specialty is given a specification, it will add, unless you have moved to a different skill in the select element's option list and then returned to Academics.

[cmho]

@korey-enright I'm having trouble replicating this—can you tell me what browser you were using?

[korey-enright]

@cmho I'm using the Firefox Developer Edition browser on a Mac

[korey-enright]

It looks like "$" is undefined, which is impacting the onclick listener? Also, when I looked at the DOM, when I selected any skill, no option had the selected attribute added, and when I typed into the input box, no value attribute was added to that element either. Though if it's relying on jQuery at all I think it might all be traceable to the same problem

(as for why it's only affecting me I have literally no idea lol)

[cmho]

I don’t think it’s jquery—$ isn’t accessible from console because of the way the Wordpress Sage framework manages script dependencies (it’s in a namespaced enclosure iirc), but there would be bigger problems if it wasn’t working at all. I’ll keep investigating.

Sent from my iPhone

On Feb 1, 2019, at 4:51 PM, Enright notifications@github.com wrote:

It looks like "$" is undefined, which is impacting the onclick listener? Also, when I looked at the DOM, when I selected any skill, no option had the selected attribute added, and when I typed into the input box, no value attribute was added to that element either. Though if it's relying on jQuery at all I think it might all be traceable to the same problem

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[sublimemarch]

I'm not able to replicate this. I'm using non-developer Firefox.

[korey-enright]

OK I figured it out! I can indeed add specialties. The reason why I thought I couldn't is that the clickable area of the add button for whatever reason is only the leftmost third of the button (for me)

[cmho]

Ahaha, yeah, I figured out that due to not flex-wrapping the row, despite the fact that i put flex-shrink on the text field, the button is sitting under the next column for some reason??? anyway i’m going to fix it soon hopefully :upside_down:

On Feb 2, 2019, at 11:08 AM, Enright notifications@github.com wrote:

OK I figured it out! I can indeed add specialties. The reason why I thought I couldn't is that the clickable area of the add button for whatever reason is only the leftmost third of the button.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cmho/solace-theme/issues/19#issuecomment-459981383, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQWQUtlQ6Ydx_Hb-SMpf3DUYArEFUbAks5vJcYRgaJpZM4adyog.

[cmho]

Fixed!