Closed Saltsmart closed 9 months ago
Thanks this is looking good. A couple more comments from me:
Sorry for not familiar with GitHub Actions! I could see some failed tests (even they are still running now). Are they related with my pull request? Please let me know if I could help improve these tests.
Thanks for this.
Thinking about this in more detail, I don't get why it needs to be part of the default settings. I can see why some users want it as part of their individual settings, in which case, they should add it to their individual global settings, but having it as part of default does not feel appropriate.
Can I recommend that you change this so that it simply adds a test case?
As another option, if you'd like to add an example to the documentation, please feel free.
My apologies for the back & forth.
Thanks for this.
Thinking about this in more detail, I don't get why it needs to be part of the default settings. I can see why some users want it as part of their individual settings, in which case, they should add it to their individual global settings, but having it as part of default does not feel appropriate.
Can I recommend that you change this so that it simply adds a test case?
As another option, if you'd like to add an example to the documentation, please feel free.
My apologies for the back & forth.
I feel very grateful for your patience. Here is a new pull request to add the example to the documentation #500. ♥
Reopen of another pull request #496, but from the dev branch. Here is the improvement for this pull request:
Here is the dev branch from V3.23.4.
Thanks for your advice! I've removed it.
I've added a file
test-cases/specials/algorithmic-and-algpseudocodex.tex
. Please review below.I have tried specialBeforeCommand: 0 and found this couldn't format the code. Here is the discussion.
what is this pull request about?
This pull request adds the support for algorithm packages, such as algorithmic and algpseudocodex
does this relate to an existing issue?
Here is the link: issue 427
does this change any existing behaviour?
yes
what does this add?
Here is a minimal example:
After merging the pull request,
latexindent.pl
could format the file as follows (with 4-space indents):how do I test this?
You can test this as the above section depicts.
anything else?
No more further comments. Best wishes for you and your family!