search

cminkoff / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Make backend: LOCAL_SRC_FILES list generated for Android isn't relative to source directory #339

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a minimal test.gyp file referencing src/Main.cpp
2. Run gyp --depth=. --generator-output=build -Gandroid_ndk_version=r8e 
-Dtarget_arch=arm test.gyp
3. Check LOCAL_SRC_FILES in the generated makefile.

What is the expected output? What do you see instead?

The path should have been converted into $(srcdir)/src/Main.cpp. Instead 
src/Main.cpp is referenced - which cannot be found of course.

What version of the product are you using? On what operating system?

I'm using a two months old clone of 
https://chromium.googlesource.com/external/gyp.git, the issue is still present 
in the repository however. Operating system is Linux x64.

Please provide any additional information below.

The issue is caused by the following line in pylib/gyp/generator/make.py:

    self.WriteList(map(self.Absolutify, filter(Compilable, all_sources)),
                   'LOCAL_SRC_FILES')

An additional call to Sourcify is required here. Adding it makes projects 
compile successfully:

    self.WriteList(map(Sourceify, map(self.Absolutify, filter(Compilable, all_sources))),
                   'LOCAL_SRC_FILES')

Original issue reported on code.google.com by t...@adblockplus.org on 16 May 2013 at 7:50