variables expansion needs to take current directory into account

[GoogleCodeExporter]

It looks like gyp may cache the value of variables. This proves problematic if 
the variable has an expansion that depends upon the current directory.

For example, we include 
http://src.chromium.org/viewvc/chrome/trunk/src/mojo/public/bindings/mojom_bindi
ngs_generator.gypi in multiple gyps. We want to set mojom_base_output_dir in 
mojom_bindings_generator.gypi, but because mojom_base_output_dir may be cached 
not all places that include mojom_bindings_generator.gypi get the right value. 
To work around this every place that includes mojom_bindings_generator.gypi has 
to explicitly set mojom_base_output_dir .

Original issue reported on code.google.com by sky@chromium.org on 3 Apr 2014 at 9:58

[GoogleCodeExporter]

Original comment by mark@chromium.org on 3 Apr 2014 at 10:01

• Changed state: Accepted

[GoogleCodeExporter]

The solution will be to make the cache key include the directory that the 
command is run from. That should work for Mojo, right, Scott?

Original comment by mark@chromium.org on 3 Apr 2014 at 10:29

[GoogleCodeExporter]

Yes, I believe that should work for Mojo.

Original comment by sky@chromium.org on 3 Apr 2014 at 10:32

[GoogleCodeExporter]

GYP r1913

Original comment by mark@chromium.org on 5 May 2014 at 4:24

• Changed state: Fixed