search

cminkoff / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

win_tool.py should filter noisy messages from link.exe #500

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. git clone https://chromium.googlesource.com/external/gyp
2. cd gyp
3. set GYP_GENERATORS=ninja
4. gyp test\win\linker-flags\ltcg.gyp --depth=.
5. ninja -C out\Default test_ltcg_on

What is the expected output? What do you see instead?
The expected output is:
=====
ninja: Entering directory `out\Default'
[3/3] LINK_EMBED test_ltcg_on.exe
=====

The actual output is:
=====
[3/3] LINK_EMBED test_ltcg_on.exe
Generating code
Finished generating code

=====

We have already suppressed messages like that, e.g., 
https://codereview.chromium.org/298863003
Hence it makes sense to filter the above messages as well.

Original issue reported on code.google.com by yukawa@chromium.org on 10 Oct 2015 at 9:16

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
This should be addressed by 
https://chromium.googlesource.com/external/gyp/+/c3d861c8bca42f942e829b77b088627
5ae0a40b8

Original comment by yukawa@chromium.org on 13 Oct 2015 at 6:35