search

cmintey / wishlist

Wishlist is a self-hosted wishlist application that you can share with your friends and family. You no longer have to wonder what to get your family for the holidays, simply check their wishlist and claim any available item!
MIT License
55 stars 1 forks source link

Bug: Wish URL overwritten to bad URL after extraction #124

Closed tpansino closed 3 months ago

tpansino commented 4 months ago

Describe the bug

When attempting to add certain item URLs the URL is overwritten after extraction runs, causing the URL to be invalid. There doesn't appear to be a way to fix the URL after this happens either.

To Reproduce

  1. Open the dialog to add a new item to a wishlist
  2. Enter the URL https://www.rei.com/gift-card/purchase
  3. Observe extraction runs and the URL is changed to https://www.rei.com/null
  4. Attempt to change the URL back to https://www.rei.com/gift-card/purchase, observe extraction runs again and it is reset back to https://www.rei.com/null

Expected behavior

  1. The URL after extraction shouldn't have a null in it - I'm guessing that's an unset variable that failed to extract properly because of the site
  2. The URL should (IMO) "stick" the second time it's set, and not attempt to rerun extraction on the page. (If you want to preserve the ability to re-run the extraction logic, maybe add a refresh button/icon to the right of the Item URL text box for that?)

Screenshots

Screenshot 2024-07-23 at 10 40 20

Desktop (please complete the following information):

cmintey commented 4 months ago

Interesting. We try to resolve the url by using some opengraph properties when possible. In this case, it seems the issue actually lies on REI's website. I don't know how common this is, but I agree, there should be a way to override this image

tpansino commented 4 months ago

Oh interesting. I'll try to send them a support ticket for that, just to try to fix it on both sides.

tpansino commented 3 months ago

The fix works great, thanks @cmintey for all your hard work. 🏆