search

cmip6dr / Request

Request specification (which variables for which experiments, etc)
2 stars 0 forks source link

Type of basin@Ofx should be "int" instead of "integer" (DR 01.00.16) #66

Closed jypeter closed 6 years ago

jypeter commented 6 years ago

CF says that The netCDF data types char, byte, short, int, float or real, and double are all acceptable, so I guess that the type of basin@Ofx should be int

martinjuckes commented 6 years ago

The type column is used by CMOR .... so integer (as in CMIP5) is the correct value. I'll check with the CMOR team to see what their view is (https://github.com/PCMDI/cmor/issues/299 )

taylor13 commented 6 years ago

@jypeter The original CMOR tables were designed solely for CMOR1, which was written in Fortran (only!), so we adopted the terminology "integer" so that it would be correctly handled in Fortran. When we wrote CMOR2 (in C with Fortran and python interfaces), we wanted it to be backward compatible with the old CMOR tables, so we retained the old names, which I think we shouldn't change at this point. The netCDF type for "basin" is indeed "int", to answer your specific question, and both flag_values and flag_meanings should be stored as indicated in https://goo.gl/neswPr .

senesis commented 6 years ago

Please remember that CMOR is not the sole user software of DR details. dr2xml is antoher user software. Being pro-active with all software users would be fair.

martinjuckes commented 6 years ago

I'll add "Data type is specified using Fortran code words: character, double, integer, real " to the description of the type attribute (http://clipc-services.ceda.ac.uk/dreq/u/ATTRIBUTE::CMORvar.type.html ) for the sake of transparency and a "forward look" issue to consider a change for CMIP7: https://github.com/cmip6dr/cmip7_forward_look/issues/18