cmllr / redundancy

Redundancy is a great lightweight software to create a cloud storage server without having too much load on your server.
GNU General Public License v3.0
27 stars 1 forks source link

add meta tag to forbid user scalability on mobile devices #144

Closed christianmalek closed 9 years ago

christianmalek commented 9 years ago

add <meta name="viewport" content="initial-scale=1.0, user-scalable=no" />

elomatreb commented 9 years ago

Don't do that. Disabling user-scaling severely reduces accessibility, for example for people who have weak eyesight.

width=device-width, initial-scale=1.0 is pretty much the best viewport tag you could use.

christianmalek commented 9 years ago

OK. The problem is that e.g. Chrome zooms in when you select an text field. How can I avoid that behaviour?

christianmalek commented 9 years ago

This is related to mobile devices/browsers.

elomatreb commented 9 years ago

Why would you want to stop that? I, personally, did not yet use Redundancy on a mobile device, but if the design breaks you should fix the design, not disable zooming.

christianmalek commented 9 years ago

The design doesn't break. According to http://stackoverflow.com/questions/7073396/disable-zoom-on-input-focus-in-android-webpage it isn't possible without disabling zoom.

I wanted to disable it because in my humble opinion it disturbs the "app feeling". Native mobile apps aren't zoomable. So why should the web app be zoomable? I did a proof-of-concept to see what it looks like when I embed the web app into a native android app with the webview component.

cmllr commented 9 years ago

Should this now be implemented or not? I'm confused.

cmllr commented 9 years ago

bumb

christianmalek commented 9 years ago

I would prefer it.

squarerootfury notifications@github.com schrieb am Fr., 8. Mai 2015 07:25:

bumb

— Reply to this email directly or view it on GitHub https://github.com/Redundancycloud/redundancy/issues/144#issuecomment-100103861 .

elomatreb commented 9 years ago

This is probably a matter of opinion. I do not think websites should mirror the behavior of native apps (There is a reason they are not a native app), especially if this might cause problems for people using other devices or people with something like weak eyesight.

cmllr commented 9 years ago

Whould that be an idea to do this only on mobile devices?

elomatreb commented 9 years ago

Not reliable and way too much effort, I think.

I personally don't use smartphones, so I do not exactly have experience with what is discussed here, but I would assume that zooming in on focused inputs is a feature that can be disabled in a users personal settings?

cmllr commented 9 years ago

This would be the best idea. I will add it to the user options to allow scrolling.

elomatreb commented 9 years ago

I meant device settings, but this works too.

I would suggest to disable it by default though, since an application should be accessible by default.

cmllr commented 9 years ago

@Phisherman @elomatreb does this collide with the old meta viewport?

I mean when the settings would be disabled and/ or nobody is logged in, what should be used?

<meta name="viewport" content="width=device-width, initial-scale=1.0">

elomatreb commented 9 years ago

width=device-width, initial-scale=1.0 is pretty much the best you could do. Makes it easy to work with media-queries, but does not have any real accessibility drawbacks.

cmllr commented 9 years ago

Should this be on any device or just mobile ones?

christianmalek commented 9 years ago

Desktop browsers force scaling if you want to, so you don't need to distinguish between mobile and desktop browsers.

It could also be possible that mobile browsers ignore it.

cmllr commented 9 years ago

Issue was fixed. Meta tag is added when the user activates the setting.