search

cmmr / virmap

GNU Affero General Public License v3.0
25 stars 14 forks source link

Docker image #6

Open sminot opened 5 years ago

sminot commented 5 years ago

It would be very helpful if you could add a Dockerfile to the repository to give people a common basis for how to install and set up the tool. With a Dockerfile in the repository, you can set up a service like Quay to automatically build a Docker image from every new version that you push to GitHub, which would make it extremely easy for other people to run the tool in the exact same way that you do.

While this may seem like a bit of work up front, it will mean that you will never have to help troubleshoot anybody's installation in the future, which could help justify spending a bit of time on it. Thanks!

sminot commented 5 years ago

I'm also happy to help you put the Dockerfile together if you haven't tried that out before. Let me know what I can do to be helpful.

najami commented 5 years ago

Hi Sam - Thank you for bringing this up. Our plans are to develop a web application in the near future. Please let me know if we can help you run any data in the meantime.

sminot commented 5 years ago

If I were to make a fork and try to put together a good Dockerfile, would you be willing to merge my Pull Request and add it to the repo?

torptube commented 4 years ago

I built a DockerFile file for this, however I don't understand Docker and how it uses disk enough to confidently post the DockerFile. The database is quite large, so embedding it in a Docker image seems like a bad idea.

dansmith01 commented 4 years ago

@torptube, you can post just the dockerfile itself. Then when someone builds it into an image it'll download the database at that point. But providing the database embedded in a public docker image would work just as well, since the user would have to download the database either way.