vercel[bot]
commented
6 months ago Someone is attempting to deploy a commit to a Personal Account owned by @cmnord on Vercel.
@cmnord first needs to authorize it.
Open menonsamir opened 6 months ago
vercel[bot]
commented
6 months ago Someone is attempting to deploy a commit to a Personal Account owned by @cmnord on Vercel.
@cmnord first needs to authorize it.
vercel[bot]
commented
6 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| jep | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 20, 2024 11:51pm |
cmnord
commented
6 months ago 
menonsamir
commented
6 months ago This looks great! I'll look at the preview branch for UI later, but looks good overall. Can you allow self-kicking? I can imagine if a player accidentally joins on two devices, they might equally want to kick device A from device B or self-kick from device A.
Sure, self-kick is a good idea. I think the UI may be a bit tricky, since we also have the name editing UI for yourself.
Where do you think the kick button (currently an 'x') should go overall? Wherever we choose, I'd like to make it consistent for your player and the other ones. Here are some options I've thought of:
Between the edit icon and the crown
Below the crown
Don't show crowns before any answers have been given (when kicks are possible), and put the kick button below the edit button
The main issue with (1) is that the kick button (an 'x') may look like it might just 'clear' the name input. My current inclination is (3), perhaps with the kick button a little lower, and maybe a red accent on highlight (so that it's clear this is a significant action). If we wanted to be as clear as possible, we could also make this button actually say 'Kick', though this is uglier (the button does at least disappear after the first question).
Adds a button that allows kicking of a player.
The kick button disappears after the first clue is answered.