search

cmolinan / Portfolio-project

This Portfolio was built entirely in HTML/CSS and JavaScript for DOM Manipulation, using technologies such as Flexbox and Grid, and applying Responsive design. It is based on a FIGMA design
https://cmolinan.github.io/
4 stars 0 forks source link

issues found in carlos mobile version #5

Open mohamed20163858 opened 2 years ago

mohamed20163858 commented 2 years ago

hi Carlos your design is fascinating we liked a lot your choice of colors and your implementation of Figma design however here is a list of things we thought you need to invest more time to improve:- 1) you need to put a link to your website inside your logo class 2) your CSS code is too long because you have repetitive lines of code you can reduce your total lines of code by creating general classes and including them inside your HTML tags this will make your code more readable and easy to follow 3) try to centralize your page content in the middle because aligning your content in the left leave a lot of space and disturb the view of your page a little bit 4) I saw there were big margin values between each section try to decrease that a little bit this will your website more visual as I think finally, you did a great job till now and we really enjoyed seeing your website congratulation to reach this far 🥳 🥳 🥳

cmolinan commented 2 years ago

Thanks for your comments. Guess I solved all the points you recommended