cmolinan / To-Do-List-with-Testing

"To-Do List" is a minimalist website that helps organize your day. It simply lists the things you need to do and allows you to mark them as complete. It was built primarily with JavaScript, ES6, and Webpack. Also, includes testing with Jest.
https://cmolinan.github.io/To-Do-List/
1 stars 0 forks source link

Remove redundant code from tests #6

Open limavfabio opened 2 years ago

limavfabio commented 2 years ago

Hey @cmolinan and @DhuruvSingh. Good job on the project! I really like the way you implemented the tests, but I think that they could be even better if you fixed the following:

The tests on library.test.js mock a DOM using document.body.innerHTML, but some part of the content is unnecessary. I run the tests with only this HTML inside the mock DOM:

`

` And the tests passed fine. I think it would make your tests cleaner and easier to understand if you removed the superfluous code. Other than that, your project is looking fantastic! Keep up the hard work 💪🏽 !
cmolinan commented 2 years ago

Yes, you are right !!