search

cmooref17 / Lethal-Company-TooManyEmotes

https://thunderstore.io/c/lethal-company/p/FlipMods/TooManyEmotes/
MIT License
16 stars 10 forks source link

Incompatibility With Embedded Dependencies (MoreCompany) #30

Open ChloeDawn opened 10 months ago

ChloeDawn commented 10 months ago

Using Pups Cute Cosmetics as an example, when it and TooManyEmotes are installed together the cosmetics with physics become static. After reviewing the log output and mod files, the issue appears to be that TooManyEmotes loads MoreCompany cosmetics too early / without first loading any embedded dependencies. PupsCuteCosmetics embeds JigglePhysicsPlugin within its cosmetics directory (BepInEx/plugins/PupVR-Pups_Cute_Cosmetics/MoreCompanyCosmetics/JigglePhysicsPlugin.dll) and when TooManyEmotes is present, this dependency is loaded after cosmetics are loaded, causing script references to error. Installing JigglePhysicsPlugin as a top-level mod resolves this issue.

I do suspect this may be a poor implementation on the side of Pups Cute Cosmetics, so I understand fully if this is not something you wish to support. From what I understand, MoreCompany searches for cosmetics to cache every startup? So it may actually be an undesired side-effect that it loads embedded dependencies.

TooManyEmotes version: 1.7.18 Pups Cute Cosmetics version: 1.1.5 Log output: LogOutput.txt gist

cmooref17 commented 10 months ago

I can definitely look into this! I might have more time this weekend, but hopefully I can get something figured out.

cmooref17 commented 10 months ago

Just updating that I havne't had too much time to look, but I will look as soon as I can :)

cmooref17 commented 10 months ago

Sorry for being slow, but this hasn't resolved itself has it? I might be able to add this mod as a soft dependency and see if that fixes anything. I'll check again once I get home to make sure that's the best option.

21Sumter commented 9 months ago

try installing advanced company, maybe this will solve your problem